On Fri, Jul 17, 2026 at 1:37 PM Peter Smith <[email protected]> wrote: > > Some review comments for v21-0002. > > ====== > Commit message. > > 1. > Add ProcessSchemaExceptTables() to qualify each mention's EXCEPT > entries, build a sorted signature per schema OID, and compare it > against any prior mention of the same schema in the same statement, > erroring on a mismatch. It also checks there are no clashes of the > same schema with or without EXCEPT. > > ~ > > IMO it's too confusing to explain the implementation detail here > instead of the purpose. Also, it should say "with *and* without". > > SUGGESTION > Add ProcessSchemaExceptTables(), which errors if the same schema is > mentioned more than once with EXCEPT, or both with and without EXCEPT. > It also checks that a schema's EXCEPT clause only lists tables from > that same schema. >
Updated as suggested in v22. I think patch 002 is now in good shape to be merged into patch 001. Thoughts? -- Thanks, Nisha
