Hi hackers, > My primitive idea for fix is to introduce a new TOC entry to record the OWNER > command, in the pg_dump. Unlike the normal CREATE SUBSCRIPTION, this entry > can be handled as RESTORE_PASS_POST_ACL. > I'm locally working on the idea and will post tomorrow.
So here is a patch. While coding, I found another issue that TOC entry for "SUBSCRIPTION TABLE" may not be skipped in case of --no-subscriptions. This can be an issue when: 1) there are tuples in pg_subscription_rel, 2) pg_dump is done with --binary-upgrade then 3) pg_restore is done with --no-subscription. I think it seldom happens, but I could not find reasons to retain. How do you feel? Best regards, Hayato Kuroda FUJITSU LIMITED
0001-ignore-SUBSCRIPTION-TABLE-in-case-of-no-subscription.patch
Description: 0001-ignore-SUBSCRIPTION-TABLE-in-case-of-no-subscription.patch
0002-Fix-pg_upgrade-failure-with-subscriptions-using-fore.patch
Description: 0002-Fix-pg_upgrade-failure-with-subscriptions-using-fore.patch
