On Wed, Jul 22, 2026 at 10:00 PM Anthonin Bonnefoy <[email protected]> wrote: > > Hi, > > Currently, any OOM triggered within getNotify and getParameterStatus > will drop the connection and set error_result=true. > > However, this error is currently ignored in 2 spots: > getCopyDataMessage and pqFunctionCall3. They will continue to process > the dead connection without reporting the error. > > The attached patch fixes the issue by returning the error (-2 for > getCopyDataMessage, the PGresult for pqFunctionCall3) whenever a fatal > error was triggered.
Thanks for the patch. I traced through this and it looks correct. I confirmed by code inspection that the third caller of these helpers, pqParseInput3(), does not need the same change: it already has the check, and handleFatalError() also flushes the input buffer and sets asyncStatus = PGASYNC_READY, so it can't spin. The two functions you patched are the only ones with private loops that ignored error_result, so the scope looks complete. +1 from me. > > Regards, > Anthonin Bonnefoy -- Regards, Ewan Young
