On Wed, 01 Oct 2025 15:25:51 +0200
Laurenz Albe <[email protected]> wrote:

> On Tue, 2025-09-30 at 22:31 +0900, Yugo Nagata wrote:
> > > You used the <option> tag, which I believe is correct, but the surrounding
> > > code uses <literal>.  I don't think it renders differently, but I think it
> > > would be good to use the same tag.  I suggest that you change the
> > > surrounding code to use <option> as well.
> > 
> > Agreed. I fixed it to use <option>, as well as in other place where I think
> > <option> is appropriate. Please find the attached patch.

I'm just resending the same patch because CommitFest reports that it needs a
rebase, although it still applies cleanly.

Regards,
Yugo Nagata

> 
> I'll mark it "eeady for committer".  A committer can decide whether to apply
> this to HEAD or not.  I probably would, and revert it if PostgreSQL + Meson +
> Windows learns to produce bitcode.
> 
> Yours,
> Laurenz Albe

-- 
Yugo Nagata <[email protected]>
diff --git a/doc/src/sgml/jit.sgml b/doc/src/sgml/jit.sgml
index 44e18bf1a6f..d5373061e3a 100644
--- a/doc/src/sgml/jit.sgml
+++ b/doc/src/sgml/jit.sgml
@@ -36,7 +36,8 @@
    <acronym>JIT</acronym> compilation using <ulink
    url="https://llvm.org/";><productname>LLVM</productname></ulink> when
    <productname>PostgreSQL</productname> is built with
-   <link linkend="configure-with-llvm"><literal>--with-llvm</literal></link>.
+   <link linkend="configure-with-llvm"><option>--with-llvm</option></link>
+   or <link linkend="configure-with-llvm-meson"><option>-Dllvm</option></link>.
   </para>
 
   <para>
@@ -76,6 +77,15 @@
     bodies of small functions into the expressions using them. That allows a
     significant percentage of the overhead to be optimized away.
    </para>
+   <note>
+    <para>
+    Inlining does not work if <productname>PostgreSQL</productname> is built using
+    <application>Meson</application> with
+    <link linkend="configure-with-llvm-meson"><option>-Dllvm</option></link>,
+    because the <productname>LLVM</productname> bitcode is not built.
+    See <xref linkend="jit-extensibility-bitcode"/> for more details about bitcode.
+    </para>
+   </note>
   </sect2>
 
   <sect2 id="jit-optimization">
@@ -133,7 +143,7 @@
    <para>
     If <xref linkend="guc-jit"/> is set to <literal>off</literal>, or if no
     <acronym>JIT</acronym> implementation is available (for example because
-    the server was compiled without <literal>--with-llvm</literal>),
+    the server was compiled without <option>--with-llvm</option>),
     <acronym>JIT</acronym> will not be performed, even if it would be
     beneficial based on the above criteria.  Setting <xref linkend="guc-jit"/>
     to <literal>off</literal> has effects at both plan and execution time.

Reply via email to