Hi, I think this fix is reasonable. The current assignment:
sd->smgr.skip_fsync = skip_fsync && !SmgrIsTemp(smgr); does not match the comment that temporary relations should never be fsync'd, nor the existing smgr write path logic. The condition should be: sd->smgr.skip_fsync = skip_fsync || SmgrIsTemp(smgr); Although skip_fsync is not currently consumed, this fixes the semantics and avoids carrying an incorrect condition into future AIO write support. Thanks.
