Tom Lane <[email protected]> writes: > Pushed with minor additional comment-smithing. I also double-checked > that macOS's current behavior applies at least as far back as > macOS 14 (Sonoma), so we should be good on any version that anyone > is likely to install PG 20 on. > > [...] > > BTW, I realized that we had no buildfarm coverage of --enable-dtrace > on macOS, so I've enabled that on indri.
Thanks for pushing, and for the extra comment polish. Having --enable-dtrace enabled on indri should help catch macOS-specific issues sooner. чт, 30 июл. 2026 г. в 05:33, Tom Lane <[email protected]>: > Andrey Rachitskiy <[email protected]> writes: > > I've > > rewritten the probes.d note along those lines and kept ssize_t/size_t > > for the smgr probes (system-supplied, matching md.c). > > > Updated patch attached. > > Pushed with minor additional comment-smithing. I also double-checked > that macOS's current behavior applies at least as far back as > macOS 14 (Sonoma), so we should be good on any version that anyone > is likely to install PG 20 on. > > I noticed that we had > > #define bool unsigned char > > in there, and tried to get rid of that, reasoning that now that we > use <stdbool.h> "bool" does not mean "unsigned char". However, macOS > rejects "bool", so I desisted. Thinking twice, it looks like we > could instead do > > #define bool _Bool > > but that seems like a matter for a separate patch, perhaps. > > BTW, I realized that we had no buildfarm coverage of --enable-dtrace > on macOS, so I've enabled that on indri. > > regards, tom lane > -- Regards, Rachitskiy Andrey
