>Original >From: Pierre Forstmann <[email protected]> >Date: 2026-08-01 23:09 >To: pgsql-hackers <[email protected]> >Cc: Zizhuan Liu <[email protected]> >Subject: Re: [PATCH] Doc: Mention OFF as an alias for EXPLAIN SERIALIZE NONE >Hello, >I have reviewed your documentation patch. > >It looks good to me except that there is a missing space between 'NONE' and >'(' in: "SERIALIZE NONE(or OFF)," >
Thank you for the detailed review. Given mixed community feedback on this patch, I plan to collect more opinions and make a final call on whether to move forward with this change. Much appreciated. >Include information on the cost of serializing the query's output data, that >is converting it to text or binary format to send to the client. This can be a >significant part of the time required for regular execution of the query, if >the datatype output functions are expensive or if TOASTed values must be >fetched from out-of-line storage. EXPLAIN's default behavior, SERIALIZE >NONE(or OFF), does not perform these conversions. If SERIALIZE TEXT or >SERIALIZE BINARY is specified, the appropriate conversions are performed, and >the time spent doing so is measured (unless TIMING OFF is specified). If the >BUFFERS option is also specified, then any buffer accesses involved in the >conversions are counted too. In no case, however, will EXPLAIN actually send >the resulting data to the client; hence network transmission costs cannot be >investigated this way. Serialization may only be enabled when ANALYZE is also >enabled. If SERIALIZE is written without an argument, TEXT is assumed. > >Could you fix this ? > >Thanks. > >The new status of this patch is: Waiting on Author This might be a separate topic. I plan to spend time later reviewing its logic and assessing implementation feasibility. Other interested hackers are free to explore and implement it early. I also have a thorny patch to resolve, this will take some time: https://commitfest.postgresql.org/patch/7075/ Fix var_eq_const: sum selectivity of all matching MCV entries instead of stopping at first match regards, -- ZizhuanLiu (X-MAN) [email protected]
