On 30.07.26 13:20, Chauhan Dhruv wrote:
Thanks for the review :)
> Instead of creating another view, I would try to add the WHERE clause
in customer_us definition itself.
Great idea! Done in attached v2. The whole-pattern WHERE clause is now
part of the existing
customers_us definition, so there is no extra view. The predicate
(p.price > 0) is deliberately trivial; as you say, the view is not
queried anywhere, so only its deparsed definition matters.
I also updated the comment above the view to mention that it covers
WHERE clauses both on pattern elements and on the whole pattern.
> Further, we usually don't drop any objects created by this test so
that they can be tested in the 002_pg_upgrade test. Please observe that
customer_us view is not dropped
hmm makes sense, will take care of it
v2 patch is attached.
Committed, thanks.
