Some review comments for v25*. ======
////////// Patch v25-0001 ////////// ====== Commit Message 1. - EXCEPT is supported only with FOR TABLES IN SCHEMA, not FOR TABLE. ~ I think you can remove this first note. It seems redundant because it's already clear (from the supported syntax etc) that this patch has nothing to do with FOR TABLE. Anyway, saying "EXCEPT is supported only with FOR TABLES IN SCHEMA" ignores the already-existing functionality of FOR ALL TABLES EXCEPT, so it could be misleading. ////////// Patch v25-0004 ////////// 1. + <para> + Replace the schema list of <structname>sales_publication</structname> with + <structname>sales</structname>, excluding only + <structname>sales.drafts</structname>. All other previously excluded tables + in schema <structname>sales</structname> are no longer excluded. Any schemas + previously in <structname>sales_publication</structname> are removed: +<programlisting> +ALTER PUBLICATION sales_publication SET TABLES IN SCHEMA sales EXCEPT (TABLE drafts); +</programlisting> + </para> IMO the word "Replace" already tells it's going to overwrite everything that may have been there previously, so the current explanation seemed unnecessarily verbose. SUGGESTION Replace the schema list of <structname>sales_publication</structname> with only schema <structname>sales</structname>, excluding only <structname>sales.drafts</structname>. ====== Kind Regards, Peter Smith. Fujitsu Australia
