On Thu, Aug 06, 2026 at 10:43:21AM +0900, Fujii Masao wrote:
> This isn't directly related to this commit, but while reading the modified
> code
> I found a small pre-existing issue in the WIN32 path.
>
> In KeepFileRestoredFromArchive(), if unlink(oldpath) fails, the error message
> reports xlogfpath, even though the file being removed is actually oldpath:
>
> if (unlink(oldpath) != 0)
> ereport(FATAL,
> (errcode_for_file_access(),
> errmsg("could not remove file \"%s\": %m",
> xlogfpath)));
>
> Should we fix that as well?Eh. Yes, that should be adjusted. Perhaps you would like to do so yourself. I don't really think it's worth bothering beyond HEAD. If you think differently, of course feel free. -- Michael
signature.asc
Description: PGP signature
