On Sat, May 9, 2026 at 6:15 PM Etsuro Fujita <[email protected]> wrote:
> On Fri, May 8, 2026 at 8:08 AM Bruce Momjian <[email protected]> wrote:
> > On Tue, Apr 21, 2026 at 05:24:59AM -0700, Etsuro Fujita wrote:
> > > "Allow the retrieval of statistics from foreign data wrapper servers
> > > (Corey Huinker, Etsuro Fujita)"
> > >
> > > This is mentioned in the Additional Modules section, presumably
> > > because it was supported in postgres_fdw, but it isn't limited to
> > > postgres_fdw, so we should move it to the General Performance section?
> >
> > Well, the full text is:
> >
> >         Allow the retrieval of statistics from foreign data wrapper servers
> >         (Corey Huinker, Etsuro Fujita) §
> >
> >         This is enabled for postgres_fdw by using the option restore_stats. 
> > The
> >         default is for ANALYZE to retrieve rows from the remote server to
> >         locally generate statistics.
> >
> > It clearly mentions in the detail that it applies only to postgres_fdw,
> > so I think it is already in the right section.  While it technically can
> > be done by any FDW, it is now only postgres_fdw so people looking for
> > postgres_fdw improvements will find it in the Additional Modules
> > section.  What we can do is to reword it to:
> >
> > -->     Allow the retrieval of statistics from postgres_fdw foreign data 
> > wrapper servers
> >         (Corey Huinker, Etsuro Fujita) §
> >
> > -->     This is enabled by using the option restore_stats. The
> >         default is for ANALYZE to retrieve rows from the remote server to
> >         locally generate statistics.
> >
> > but I think this is worse because it sounds like it can _only_ ever be
> > done by postgres_fdw.  However, if you prefer this I will make this
> > change.
> >
> > I avoided "General Performance" because frankly, it is only
> > postgres_fdw, and it not a "General" performance improvement, and we
> > have a section for postgres_fdw already.
>
> Agreed.  I think the current text is fine.

We renamed the "restore_stats" option to "import_stats".  See commit 9a08585e8.

Best regards,
Etsuro Fujita


Reply via email to