On Fri, Aug 14, 2026 at 04:08:24PM +0200, Matthias van de Meent wrote: > In line with various other efforts making things more re-entrant and > thread-safe, here's a patch that makes stringToNode (and pg_strtok > with it) thread safe.
I have been reading the patch (not tested, just looking at the diffs), and using a context as you are doing sounds like an acceptable thing to do to remove the static pointer used by pg_strtok(). At least the change makes sense here when taken in isolation. > There are other things we could do to improve this code (e.g. > de/serializaing based on node descriptors instead of generated > functions), but I consider such improvements to be out of scope for > this patch; the attached is just a simple move from global variables > to a context struct passed down the call stack. That sounds fair. Any thoughts or comments from others? -- Michael
signature.asc
Description: PGP signature
