Hi, Tom! > Here's a patch to try to clean that up. I think it is wrong that > the extension modules don't use hek2cstr, so I made them do so. > (But we probably shouldn't back-patch that: it's a user-visible > behavioral change and we've not gotten actual field complaints AFAIR.) >
Agreed path looks good for me > > (oh, and for extra credit: why is there a second call of hv_iterinit > > in plperl_build_tuple_result and plperl_modify_tuple?) > > That seems to be just cargo-culted, so I removed those calls. > hv_iterinit is good practice to clean up the iterator state, but here it's redundant and misleading. -- Regards, Rachitskiy Andrey
