Re: [PATCH] Preserve replication origin OIDs in pg_upgrade

[Ajin Cherian]

On Fri, Aug 14, 2026 at 3:29 PM Hayato Kuroda (Fujitsu)
<kuroda.hay...@fujitsu.com> wrote:
>
> Dear Ajin,
>
> Thanks for updating the patch. I think the patch series is mostly good.
> Few cosmetic comments:
>

I have addressed these comments.

On Mon, Aug 17, 2026 at 7:29 PM Rui Zhao <zhaorui...@gmail.com> wrote:
>
> Hi Ajin,
>
> v15 applies to master (eb983d0a94), builds warning-free, make check 245/245,
> pg_upgrade TAP 148/148.  I also ran a real pg_upgrade with one origin in each
> of the three states -- never advanced, advanced to 0/0, advanced to a real
> LSN -- and all three keep their tracking state:
>
>     origin           old cluster   new cluster
>     o_never          untracked     untracked
>     o_tracked_zero   0/00000000    0/00000000
>     o_tracked_real   0/12345678    0/12345678
>
> A test gap, a doc paragraph the pre-17 change left behind, and three small
> things.

I have incorporated your comments and your changes in a new patch v16.

regards,
Ajin Cherian
Fujitsu Australia

v16-0001-Preserve-subscription-OIDs-during-pg_upgrade.patch
Description: Binary data

v16-0002-Preserve-replication-origin-OIDs-during-pg_upgra.patch
Description: Binary data