The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Hello,

I have reviewed this patch and it looks good to me.

I have built and tested with both make and meson.

Running make check-world is OK and running  with meson:

cd build
meson test -q --print-errorlogs

reports:

Ok:                 356
Expected Fail:      0
Fail:               0
Unexpected Pass:    0
Skipped:            35
Timeout:            0

There is no SQL compliance to check and I don't think documentation should be 
updated.

Regards
PF

The new status of this patch is: Ready for Committer

Reply via email to