> I initially thought about that approach too, but an assertion also > uses that check. > This is explained in the commit message: > > > Skip invalid indexes, as the planner does. The test belongs here rather > > than in IsIndexUsableForReplicaIdentityFull(), whose other caller is an > > assertion that would then trip over an index DROP INDEX CONCURRENTLY has > > just invalidated but that still finds tuples fine.
Oh sorry, I didn't notice it. Make sense. I was wondering if there is a way (and whether it even makes sens to make this test fail faster? Right now, if we remove `idxRel->rd_index->indisvalid &&` the test just hangs until the overall timeout is hit and we're not getting any meaningful message. Kind regards, Miłosz Bieniek
