> +1 for fixing that. Also I think project style is to write sizeof
> with parens.
For as long as I can remember, I have written it with parens when applied
to a type, but without parens when applied to a variable. That's long enough
that I had forgotten why, but Gemini reassures me there's not only a basis
in the language spec (the parens are mandatory when applied to a type) but
also a widely-practiced convention to visibly distinguish the two cases.
Perhaps supporting the idea of a project style that differs, many of
the first hits in our tree from
grep -r '\<sizeof[[:space:]]*[^([:space:]]' src
turn up in imported code like pg_bsd_indent and zic. But I do also turn up
35 matching lines in src/{backend,interfaces}, so there is some precedent
within the project.
Regards,
-Chap
