Hi, On Sat, Aug 29, 2026 at 4:23 AM Antonin Houska <[email protected]> wrote: > > Thanks! I'm just thinking about this comment: > > + /* The CONCURRENTLY path does not write logical rewrite mappings. */ > > IMO it makes no sense to rewrite the logical mappings as long as REPACK > (CONCURRENTLY) changes visibility information (i.e. it's MVCC-unsafe). Once we > implement the MVCC-safety, we should not remove this check unless we implement > the rewriting of the mappings for user catalog tables - that might also be > worth mentioning in the comment. > > So far, I'd consider the MVCC-unsafety the primary reason to prohibit REPACK > (CONCURRENTLY) (or anyother MVCC-unsafe command) on the user catalog tables, > because it can make the contents of those tables invisible to the output > plugin at some point.
Thanks for pointing this out. I read the docs related to MVCC-safety of concurrent repack. I reworded the comment as you suggested. Feel free to suggest changes to it if any. Please find the attached v2 patch. -- Bharath Rupireddy Amazon Web Services: https://aws.amazon.com
v2-0001-Restrict-REPACK-CONCURRENTLY-on-user-catalog-tabl.patch
Description: Binary data
