The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation: tested, failed
Hi! This looks like a reasonable improvement. However, i have some questions about realization. 1. In general case we use $$ to add pid to temp_path, whereas on windows we do not use this. I believe, this can cause name collision, which is not great. 2. In documentation [1] we do not specify that archive command needs to be atomic. Furthermore, we use actual cp as an example. This can lead to similar problems not only in tests. Thank you! [1] https://www.postgresql.org/docs/current/continuous-archiving.html#BACKUP-ARCHIVING-WAL Best regards, Stepan Filippov. The new status of this patch is: Waiting on Author
