On Thu, Sep 3, 2026 at 9:12 AM Zhijie Hou (Fujitsu) <[email protected]> wrote: > > Hi, > > I noticed one comment in the launcher that can be removed: > > if (!retain_dead_tuples) > /* XXX unclear why we don't request logical > decoding disable */ > ReplicationSlotDropAcquired(false); > > Since the conflict detection slot is a physical one, there is no logical > decoding state to disable when dropping it.
I agree. However, the comments never mention that this is a physical slot, making it easy to misconstrue it as a logical one. Do you think we can add the keyword 'physical' in the comment above this Drop() or/and above CreateConflictDetectionSlot or/and above macro CONFLICT_DETECTION_SLOT? > The condition it depends on is also > self-evident from the surrounding code and the block comment above, which > already explains why the slot is dropped. So here is a patch to remove the XXX > comment.
