On Thu, Sep 03, 2026 at 02:51:28PM +0900, Michael Paquier wrote: > These two new tests for a live server, one failure where the new port > and old ports do not match, and one failure where we are checking the > old server with a correct new port, look like acceptable additions > here. Will test a bit more, and apply on HEAD, I guess.
So, one day later fairywren happens to be complaining: https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=fairywren&br=master The gist of the issue is that the cluster is not recognized as running, not considering that a live_check should happen, and it fails. I am guessing that this points out to an issue similar to what you have tried to work around with in 003_logical_slots with a hardcoded sleep, something that we do already once too much. That's, like pg_ctl, a timing issue on WIN32 with pg_upgrade --check, and that has been around for a long time. Rather than adding one of these annoying 3-second sleeps, I'm thinking about just adding a skip block for WIN32, I guess, as the test is not showing any instability in other animals as far as I can see. And live checks are still useful to cover. -- Michael
signature.asc
Description: PGP signature
