Hi all, On Mon, Sep 7, 2026 at 11:12 AM Ilya Gladyshev <[email protected]> wrote: > > Hi all, > > I noticed redundant path_nulls checks in setPathObject and setPathArray, > so here's a small refactoring patch to remove them. > > - Both checks were introduced in c694701 (12 May 2015, "Additional > functions and operators for jsonb") with the functions' initial code. > > - Both functions always had a single call site, `setPath`, as they are > internal implementations for the two cases (array/object) in a generic > function. > > - Later, in 1edd4ec (4 Oct 2015, "Disallow invalid path elements in > jsonb_set"), the path_nulls check was propagated into setPath itself. > > If desired, those conditions can be transformed into Assert()s with a > comment about setPath() validation. >
Thank you for the patch. I reviewed and tested this patch. The path_nulls[level] check is already done in setPath() before calling setPathObject() or setPathArray(). I also checked the call sites and confirmed that both functions are only called from setPath(), so the checks removed by the patch are indeed redundant. I didn't find any issues with the patch. It looks good to me. Regards. Solai
