Hello,
I have reviewed the pg_upgrade_replica implementation, and I couldn't spot
any issue.
The tool addresses a real operational problem: standby downtime during
pg_upgrade
can take many hours. This solution provides a practical way to rebuild
standbys without a full re-clone.
The design leverages existing, well-tested components. It uses pg_basebackup
--incremental and pg_combinebackup which already exist and work reliably.
This reduces the amount of new code that needs maintenance and testing.
The manifest format is simple and line-based. Each component has its own
small parser, which keeps things simple and reduces coupling between tools.
The validation strategy is comprehensive. The tool checks that the old standby
was caught-up to the exact checkpoint before proceeding. This validation
happens early, so problems are detected and reported quickly rather than
appearing later.
The operation is explicit and clear. The operator runs the tool on
each standby,
so it is obvious what is happening. If something fails, running it again is
straightforward.
+1
Florin
--
* Florin Irion *
* https://www.enterprisedb.com <https://www.enterprisedb.com/>*
