On Wed, Sep 09, 2026 at 02:23:35PM +0900, Michael Paquier wrote: > Similarly to Horiguchi-san's comments, I think that the tests could be > trimmed even more. I see no need for at least: > - "gset NULL interpolates as SQL NULL" > - "gset empty string stays empty" > - "gset NULL is bound as the string NULL in extended and prepared > modes"
Yeah, I'm still unconvinced by the value brought here in terms of cross-checking an actual NULL and a NULL but written as a string. The first test proposed is also good enough to check that we generate a NULL variable through setNullValue()->putVariableValue(). So kept only the first test, applied the result. > At the end I would just keep the "pgbench gset command with NULL" bit, > which should be enough to cover readCommandResponse(), no? No need to > be fancy, efficient is fine and saves runtime cycles. Ditto about the doc suggestion. If somebody is excited enough about this part, please feel free.. -- Michael
signature.asc
Description: PGP signature
