> > Not critically important but note that the PopActiveSnapshot and
> > InvalidateCatalogSnapshot call and the comment about "giving up if there
> > is still an active or registered snapshot" have a close relationship; I
> > think it would make sense to keep them together.  I would add your new
> > test-and-ereport just before the PopActiveSnapshot() call, to avoid
> > breaking that.
>
> Good catch. +1 for doing that.

Sure, that works. See the attached.

I think as this is an error reporting bug, maybe we should backpatch to 19?

Sami Imseih
Amazon Web Services (AWS)

Attachment: v3-0001-Fix-WAIT-FOR-rejection-errors.patch
Description: Binary data

Reply via email to