On Fri, Sep 11, 2026 at 11:33 AM Chao Li <[email protected]> wrote:
> V2 LGTM.

Thanks for the review!


> One nitpick is that, the fix covers both COMMIT and PREPARE TRANSACTION, but 
> v2 only adds a regression test for the COMMIT case. Should we test both paths?

I think the COMMIT test is enough for this small assert-only fix.

But,iIf many others prefer explicit coverage for PREPARE TRANSACTION as well,
I'm fine with adding that test. It would probably require some additional test
logic to handle environments where max_prepared_transactions is disabled
(e.g., add "skip" like prepared_xacts.sql does).

Regards,

-- 
Fujii Masao


Reply via email to