On Fri, Sep 11, 2026 at 9:59 PM vignesh C <[email protected]> wrote:
>
> On Fri, 11 Sept 2026 at 16:36, Amit Kapila <[email protected]> wrote:
> >
> > I am fine with the single message but how about changing the HINT to:
> > "Drop the table from the publication, or remove it from the
> > publication's EXCEPT clause, first." because the proposed message is
> > not suitable for the EXCEPT case.
>
> Here is an updated v5 version to handle the suggested change.
>
Hi Vignesh.
(I was about to post my v5 review comments when I saw this was already
pushed -- posting anyway)
+ errhint("Drop the table from the publication, or remove it from the
publication's EXCEPT clause, first.")));
Looks good, but isn't it more common for an errhint to say what
command to use instead of just "make this happen"?
e.g.
"First use ALTER PUBLICATION ... to drop the table from the
publication, or to remove it from the publication's EXCEPT clause."
======
Kind Regards,
Peter Smith
Fujitsu Australia
