On Sat, Sep 12, 2026 at 5:53 AM Corey Huinker <[email protected]> wrote:
>> No, it won't fall back; the syntax error on the remote server will >> lead to an error on the local server, actually. That isn't great, so >> I modified postgres_fdw to do the fallback. Patch attached. > > My mistake. The patch looks good. Clearly there's no sufficiently venerable > buildfarm animal that could have detected this, or else we would have found > it sooner, and it's hard to justify supporting it if we cant test it. >> e user trusts the remote to have good stats, otherwise they wouldn't use >> this option. >> >> I modified postgres-fdw.sgml as well to mention that that option is >> ignored, tweaking a phrase a bit. > > +1. Applies clean. Passes tests tho obviously the test we needed all along > would have been on a very old buildfarm animal. The wording of the > documentation change is clear. Pushed/backpatched. The regression test just uses a loopback server, so it only tests this feature against the same version... I think it would be nice if we could do so against old versions, but that would need a new testing framework that can also support other features like IMPORT FOREIGN SCHEMA, so I'd like to leave that for future work. Thanks for looking! Best regards, Etsuro Fujita
