Hi, On Sun, Sep 13, 2026 at 10:00 PM Michael Paquier <[email protected]> wrote: > > I have discarded the change of reorderbuffer.c that was in v17-0001, > and added it back to what's now v18-0001. Then applied these two > after an extra round of self-review.
Works for me. > Added also some tests for REPACK here in what's now 0002, based on the > feedback of upthread, to check that the a REPACK's rewrite does not > touch the TOAST table definition. > > > v17-0005-Add-support-for-TOAST-pointers-as-oid8.patch: It looks good to me. > > And rebased is a v18 with the three remaining pieces, plus two more > test patches: the tests of Rui with decoding and oid8 values higher > than 2^32, and my test to have the main regression test suite of > pg_upgrade run with a default oid8 in the control file higher than > 2^32, checking that assigned chunk numbers are handled correctly. Nice! These are good additions IMV. I reviewed v18 patches and I have no major comments. v18-0001-Add-support-for-oid8-TOAST-values.patch: It looks good to me. v18-0002-Add-battery-of-tests-related-oid8.patch: It looks good to me. v18-0003-Add-support-for-TOAST-pointers-as-oid8.patch: It looks good to me. v18-0005-Add-check-for-2-32-oid8-chunk-values-across-the-.patch: It looks good to me with a nit. It took me a while to figure out where the f1 column is coming from, so worth adding a comment here (it is the bytea column of the toasttest_oid8 table defined in src/test/regress/sql/strings.sql). -- Bharath Rupireddy Amazon Web Services: https://aws.amazon.com
