On Wed, Sep 16, 2026 at 4:46 PM Chao Li <[email protected]> wrote: > > > > > On Sep 16, 2026, at 13:50, Amit Kapila <[email protected]> wrote: > > > > -- > > With Regards, > > Amit Kapila. > > <v4-0001-Distinguish-publication-exclusions-in-object-addr.patch> > > V4 overall looks sold to me. Just a couple of small comments: > > 1 > ``` > -- No entry of either kind. testpub_default publishes nothing. > SELECT pg_get_object_address('publication excluded relation', > '{public, testpub_tbl1}', '{testpub_default}'); > ERROR: publication relation "testpub_tbl1" in publication "testpub_default" > does not exist > ``` > > For this new test, the error message is a little surprising to me. Since the > requested object type is "publication excluded relation", I would expect the > error message to say something like: > ``` > publication excluded relation "testpub_tbl1" in publication "testpub_default" > does not exist > ```
+1 this because maybe the reported table name really *does* exist and is part of the publication, even though the message is saying the exact opposite. ====== Kind Regards, Peter Smith. Fujitsu Australia.
