Hi Shihao, On Thu, 17 Sep 2026 22:13:02 -0400 shihao zhong <[email protected]> wrote:
> Hi Yugo, > > cfbot fails because v2 is a plain diff, and git am cannot apply it. > Attached v3 is the same change made with git format-patch, plus a > commit message. It applies to master and REL_16_STABLE through > REL_19_STABLE. > > One suggestion: EXPLAIN still shows "Inlining: true" in this case, > since it only checks PGJIT_INLINE. Maybe the note should say so. Thak you for updating the patch. I've attached an updated path incorporating your suggestion. Regards,] Yugo Nagata -- Yugo Nagata <[email protected]>
>From 318250d9ec79502e038644bd4b73d1682cc1b561 Mon Sep 17 00:00:00 2001 From: Yugo Nagata <[email protected]> Date: Thu, 17 Sep 2026 22:09:43 -0400 Subject: [PATCH v4] doc: Mention that JIT inlining does not work with Meson builds Meson builds do not generate the LLVM bitcode that JIT inlining needs. So with -Dllvm, JIT compilation works, but inlining does not. Document that in the JIT chapter, and mention -Dllvm next to --with-llvm. While at it, use <option> for --with-llvm, per review. This should be reverted once Meson learns to build the bitcode. Author: Yugo Nagata <[email protected]> Reviewed-by: Laurenz Albe <[email protected]> Reviewed-by: shihao zhong <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 16 --- doc/src/sgml/jit.sgml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/jit.sgml b/doc/src/sgml/jit.sgml index 44e18bf1a6f..fb934ce6fac 100644 --- a/doc/src/sgml/jit.sgml +++ b/doc/src/sgml/jit.sgml @@ -36,7 +36,8 @@ <acronym>JIT</acronym> compilation using <ulink url="https://llvm.org/";><productname>LLVM</productname></ulink> when <productname>PostgreSQL</productname> is built with - <link linkend="configure-with-llvm"><literal>--with-llvm</literal></link>. + <link linkend="configure-with-llvm"><option>--with-llvm</option></link> + or <link linkend="configure-with-llvm-meson"><option>-Dllvm</option></link>. </para> <para> @@ -76,6 +77,16 @@ bodies of small functions into the expressions using them. That allows a significant percentage of the overhead to be optimized away. </para> + <note> + <para> + Inlining does not work if <productname>PostgreSQL</productname> is built using + <application>Meson</application> with + <link linkend="configure-with-llvm-meson"><option>-Dllvm</option></link>, + because the <productname>LLVM</productname> bitcode is not built, + regardless of whether <command>EXPLAIN</command> shows "Inlining true". + See <xref linkend="jit-extensibility-bitcode"/> for more details about bitcode. + </para> + </note> </sect2> <sect2 id="jit-optimization"> @@ -133,7 +144,7 @@ <para> If <xref linkend="guc-jit"/> is set to <literal>off</literal>, or if no <acronym>JIT</acronym> implementation is available (for example because - the server was compiled without <literal>--with-llvm</literal>), + the server was compiled without <option>--with-llvm</option>), <acronym>JIT</acronym> will not be performed, even if it would be beneficial based on the above criteria. Setting <xref linkend="guc-jit"/> to <literal>off</literal> has effects at both plan and execution time. -- 2.43.0
