Hi, On Fri, Sep 18, 2026 at 5:03 PM Michael Paquier <[email protected]> wrote: > > On Thu, Sep 17, 2026 at 12:03:00PM -0700, Bharath Rupireddy wrote: > > Another approach is a new test module in src/test/modules (similar to > > the xid_wraparound module) with a simple SQL function that advances > > the OID counter in shared memory, similar to core's SetNextObjectId(). > > Being a test module, it doesn't impact production systems, and all the > > 8-byte TOAST chunk_id related tests added for this feature can be > > moved here and run across all BF animals. > > That could be one thing. Yes. Or perhaps not. > > > Others may have a different opinion. Meanwhile, IMHO, the remaining > > v18 tests can go in, with this discussed separately. > > OK, you're right that it also sucks to do nothing for the logical > decoding. So I think that I'll just do something for the > test_decoding TAP test.
Works for me. Thanks. > I am less convinced about the dump/restore > tests you are proposing; these are utterly bloated. Out of the 3 patches I posted here: https://postgr.es/m/calj2acumbhbgb+4d8srq9jt_zsobcavy6-10ckgswx98zdv...@mail.gmail.com, I'm fine to drop 0003 (I don't have a strong opinion on that) as mentioned here: https://postgr.es/m/CALj2ACWgpn_aWzzagrerFqD0p1kQv_iioWyJB5R8Cu8j3_yqdA%40mail.gmail.com -- Bharath Rupireddy Amazon Web Services: https://aws.amazon.com
