On Wed, 9 Sept 2026 at 14:15, vignesh C <[email protected]> wrote: > > On Wed, 27 May 2026 at 11:50, Peter Smith <[email protected]> wrote: > > > > The patch had previously been split for EXCEPT and non-EXCEPT changes. > > > > The 0001 patch was already pushed a while ago for PG19. I think now > > that 0002 patch can be revisited for PG20. > > Attached v7 version patch has the changes for the same. This patch is > the same as [1], reattaching here so it is easier for review.
v7 no longer applies cleanly to HEAD because commit 926627bf902
("Don't quote the relation name twice in EXCEPT clause errors.")
changed the same lines in check_publication_add_relation(). The
attached v8 builds the name once in this form and uses it for the
errors. While rebasing, I also had to update one test. For a temporary
table, the schema is pg_temp_N, where N depends on the backend running
the test. So the error message can vary between runs, for example:
ERROR: cannot add relation "pg_temp_14.testpub_temptbl" to publication
For this case, the regression test now uses \set VERBOSITY sqlstate
and checks only the SQLSTATE, similar to create_function_c.sql and
arrays.sql for other unstable messages.
Regards,
Vignesh
v8-0001-Use-schema-qualified-names-in-publication-add-rel.patch
Description: Binary data
