Hi Chao,

Thanks for the v5 patch (all the points that were earlier raised were
addressed). Both patches apply with git am, the build is clean with no new
warnings.

I also checked that advancing the origin doesn't leak into the rest of
subscription.sql: no later test sets a skip LSN with a valid location, and
the
new block leaves subskiplsn reset to NONE, so nothing downstream depends on
the origin position.

No further comments from me, v5 looks ready for a committer. You can create
a commitfest entry for this.

Regards,
Surya Poondla

Reply via email to