Dear Bertrand, Sawada-san,

> I wonder if it wouldn't make more sense to keep this after
> XactTopFullTransactionId
> is reset, as in v1?
> 
> Indeed, couldn't a barrier be processed during AtCleanup_Memory(), while the
> XID is still valid, and set XLogLogicalInfoUpdatePending again after this 
> call?

Per my research the function calls MemoryContextCallResetCallbacks(), which can
calls the arbitrary functions from core and extensions. So It's possible that a
random callback calls CHECK_FOR_INTERRUPTS() and consumes a barrier.

I still prefer to put after resetting the XactTopFullTransactionId.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Reply via email to