shihao zhong <[email protected]> writes: > I used Opus to analyze the new features in PG19, and it found a problem > with the "SELECT simple-expression INTO var" fast path from ce8d5fe0e28.
Good catch, and I concur with your fix. While looking at it
I also realized that the bit with
if (expr->plan == NULL)
exec_prepare_plan(estate, expr, 0);
is quite useless: we dealt with expr->plan == NULL a few lines
earlier, so this if-test can never succeed. Pushed with that
change.
regards, tom lane
