On Tue, Oct 6, 2026 at 11:16 AM Masahiko Sawada <[email protected]> wrote: > > On Mon, Oct 5, 2026 at 8:24 PM shveta malik <[email protected]> wrote: > > > > On Tue, Oct 6, 2026 at 3:57 AM Masahiko Sawada <[email protected]> > > wrote: > > > > > > On Thu, Oct 1, 2026 at 4:08 AM Nisha Moond <[email protected]> > > > wrote: > > > > > > > > On Sat, Sep 26, 2026 at 3:54 AM Masahiko Sawada <[email protected]> > > > > wrote: > > > > > > > > > > > > > > > I've incorporated your comment suggestions, and updated cosmetic > > > > > things.Please review them. > > > > > > > > > > > > > Hi, > > > > I reviewed the TAP test and it LGTM. I found no correctness issues, > > > > just a couple of nits compared to the neighboring tests. Please > > > > consider these if they look okay to you: > > > > > > > > 1) Add the sync_slot condition to injection_points_attach() similar to > > > > the neighboring tests, so the wait happens only when sync_slot itself > > > > is being created. > > > > 2) Add a note() after wait_for_event(), as in the other tests, so the > > > > test output shows when the sync is paused at the injection point. > > > > > > > > > > Both suggestions look good to me. I've incorporated these suggestions > > > and updated the comment as discussed with Amit. I've attached the > > > updated patch. > > > > > > > Sawada-san, I don't see any difference between v3 and v4, can you > > please check and confirm? > > Oops, sorry I forgot to include the changes to the patches when doing > git format-patch. I've attached the correct one. >
Thanks, the patches LGTM. thanks Shveta
