> I think your analysis is correct. The "if (TransactionIdDidCommit(xmax))" > branch cannot change the result of MultiXactIdIsRunning(), so the later check > is redundant. > > But I think we should delete the “By here …” comment and retain the “There's > no member …” comment because it explains why marking xmax invalid is safe.
Thanks for the review. Agreed, the "There's no member ..." comment now answers the question the old one asked. v2 attached. Regards, Zhao Song
v2-0001-Remove-redundant-MultiXactIdIsRunning-check-in-He.patch
Description: Binary data
