Hi Rahul, Thanks for v2. It addresses everything I raised.
I tested it on REL_19_STABLE (1a1248818fb) and master (9e7d152488f). Both patches apply cleanly and build without warnings, and the code changes are the same as in v1. The pg_waldump TAP tests pass, and the new checks behave as you described: All tests pass with v2. without 0002's C change: only the "error in WAL record at" prefix check fails without both C changes: both LSN checks fail Without the fixes, the start-at-the-bad-record case again names an LSN before the requested start point (0/017B2B78 when starting at 0/017B2C00 on master), so the test covers that case too. The commit messages look good to me. As you said, the test needs crc32c(), which only exists from 18 on, so it can't go back further than 18, while the code fix goes back to 15. The patch looks ready for a Committer. Regards, Surya Poondla
