On Tue, Oct 13, 2026 Sho Ito < mailto:[email protected] > wrote:
> I reviewed v1 on master. All core regression tests pass. > Before the patch, I reproduced the state-sharing warnings in > mode 1 and the backend crash in mode 2. Both modes complete without > warnings after the patch. I found no blocking issues. Hi Sho, Thanks for the review, and for reproducing it independently on master. The commit-fest entry is https://commitfest.postgresql.org/patch/7436/ , and cfbot is green on all platforms. If you're satisfied with it, could you mark it Ready for Committer? Since this touches both the extension-state API and eager aggregation, are you OK with resetting the fields at each copy site, or would you rather have a shared helper that does the flat copy and the resets in one place? Also can we turn the reproducer into a src/test/modules test if you'd like regression coverage for it? Regards,l Shubhankar K. Member Technical Staff Zoho Corporation From: Sho Ito <[email protected]> To: "Shubhankar Anand Kulkarni"<[email protected]> Cc: "pgsql-hackers"<[email protected]>, "pgsql-hackers"<[email protected]>, "robertmhaas"<[email protected]>, "guofenglinux"<[email protected]> Date: Tue, 13 Oct 2026 04:01:52 +0530 Subject: Re: PG19: flat-copied RelOptInfos share extension_state with the original rel On Mon, Oct 12, 2026 at 6:41 AM Shubhankar Anand Kulkarni < mailto:[email protected] > wrote: The attached patch resets the two fields at all four copy sites. Hi Shubhankar, I reviewed v1 on master. All core regression tests pass. Before the patch, I reproduced the state-sharing warnings in mode 1 and the backend crash in mode 2. Both modes complete without warnings after the patch. I found no blocking issues. Thanks, Sho Ito -- ＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝ Sho Ito (Sean) E-mail: mailto:[email protected] LinkedIn: https://www.linkedin.com/in/sho-ito-0628/ GitHub: https://github.com/sean0628/ ＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
