Re: Proposal: Conflict log history table for Logical Replication

[Zhijie Hou]

Hi,

On Tue, Oct 13, 2026 at 6:29 PM shveta malik <shveta.ma...@gmail.com> wrote:
>
> I analyzed that 'intervalstyle' could also cause correctness issue
> when reading the values. Attached the testcase with results before and
> after fix in it.
>
> The fix would be similar to DateStyle fix in build_index_key_json():
>
> +       (void) set_config_option("intervalstyle", "postgres",
> +                         PGC_USERSET, PGC_S_SESSION,
> +                         GUC_ACTION_SAVE, true, 0, false);
>
> Will analyze 'extra_float_digits' next.

Thanks!

I also re-confirmed locally that all the parameters you reported (e.g.
DateStyle, IntervalStyle, extra_float_digits) have similar issues, and setting
the GUCs manually when building the CLT row is an appropriate way to fix this.

Please see the attachment for a TAP test on top of v81 that tries to reproduce
all of them. And if we plan to fix this along with the main patch, I think it
would be worth keeping a simple test case like the attached one.

Best Regards,
Zhijie Hou

nocfbot_vTopup_81-0001-Test-for-Datestyle-IntervalStyle-extra_flo.patch
Description: Binary data