On Tue, Oct 13, 2026 at 8:31 PM Bharath Rupireddy <[email protected]> wrote: > > Hi, > > I noticed that two of the parallel vacuum's shared memory pointers > (VacuumSharedCostBalance and VacuumActiveNWorkers) are not reset on > the error path, leaving them dangling, that is, pointing to a shared > memory segment that is already gone, until the next vacuum runs in the > backend or autovacuum worker. This doesn't cause any issue today, but > IMHO it is good practice to avoid dangling pointers. > > Please find the attached patch that sets them to NULL on the error > path (the normal path resets them in > parallel_vacuum_process_all_indexes()). > > Thoughts?
+1 to explicitly clear these variables. Given that it doesn't cause any problems today, I think we can apply it only to master. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
