Hi Heikki, Thanks for reviewing the patch.
I had considered adding a separate CAC_* code as well, but since the existing code had already combined these cases under CAC_NOTHOTSTANDBY, I initially chose the smaller change and preserved that structure. I agree that distinguishing the reasons in CAC_state is cleaner. I will restore CAC_NOTCONSISTENT and use CAC_NOTHOTSTANDBY specifically for the case where hot standby is enabled and consistency has been reached, but the recovery snapshot is not yet ready. This would also avoid passing reachedConsistency through BackendStartupData. I will revise the patch accordingly and send a v2 soon. Best Regards, Nitin Jadhav Microsoft
