Hi David,

Great work, I like this idea a lot.

A few small things in 0002

1. With ST_COMPARE_RUNTIME_POINTER the typedef
uses const ST_ELEMENT_TYPE *, which for Item * becomes const Item **,
so a comparator taking Item *const * warns. ST_ELEMENT_TYPE const *
fixes it.

2. tbm_comparator() lost its const. It can take
PagetableEntry *const *.

3. The common/int.h include in tidbitmap.c is now unused.

4. tbm_shared_comparator() is missing inline in its definition.

Thanks,
Shihao

Reply via email to