Re: [PG19] psql backslash commands fail with translated messages and a non UTF-8 client encoding

[shihao zhong]

Hi,

Tom Lane <t...@sss.pgh.pa.us> writes:

> Thinking about that some more: why don't we just drop that test,
> along with the OUTPUT_CHARSET hacks, and confine ourselves to
> testing that (1) server_encoding equals client_encoding and
> (2) the translated string passes pg_encoding_verifymbstr?

Thanks for pushing the infrastructure. v8 does what you suggest,
with one more restriction: it translates only when both encodings are
UTF8.

WIN1252 accepts byte 0x81 but has no character for it. With
LANG=ja_JP.UTF-8, psql -f against a WIN1252 database sends the
Japanese label. It runs fine, but then a UTF8 client in that database
can't read pg_stat_activity:

  ERROR:  character with byte sequence 0x81 in encoding "WIN1252" has no
equivalent in encoding "UTF8"

Unpatched 19 does the same.

Thanks,
Shihao

v8-0001-psql-Fall-back-to-English-for-unsafe-hidden-query.patch
Description: Binary data