Few trivial things for v82-002:
1)
+errdetail("Prepared transactions of the subscription may hold a lock
on its conflict log table."),
I think usgae of 'its' is not very clear here. Suggestion:
errdetail("Prepared transactions of the subscription may hold a lock
on the conflict log table.")
or
errdetail("Prepared transactions of the subscription may hold a lock
on the subscription's conflict log table.")
Please change at both places if you agree.
2)
+ (void) set_config_option("datestyle", "ISO",
+ PGC_USERSET, PGC_S_SESSION,
+ GUC_ACTION_SAVE, true, 0, false);
We can move this to 003 so that complete fix is in same patch. Commit
message of 002 too does not mention this change either.
thanks
Shveta