At 2026-10-19 21:31:32, "David Geier" <[email protected]> wrote:
>Hi Matthias!
>
>Thanks for taking another look.
>
...
>>
>> This should probably check that len == sizeof(RelationData), and then
>> just use the AllocRelationData() macro used everywhere else.
>
>Changed to use AllocRelationData(). A few lines above there's already
>
>if (len != sizeof(RelationData))
> goto read_failed;
>
>Hence, no need for an assertion.
>
>> 0003: I agree with Alvaro's comment; if moving ForeignKeyCacheInfo to
>> its own header would also solve the issue then that's preferred.
>
>I'm waiting for Alvaro's and Peter's reply before changing that part.
>
>Any thoughts from your side regarding moving ForeignKeyCacheInfo into
>its own header vs building support for anonymous structs/unions in
>gen_node_support.pl?
...
>* The lmgr.h include is unnecessary. Removed.
>* The miscadmin.h include is necessary for MyDatabaseId.
>
>
>I've also created a commitfest entry, see [1].
>
>--
>David Geier
Hi,
Thanks for your patches.
There is still a crash in the v5 patch series, similar to the predicate crash
that Haibo already mentioned.
Minimal reproduction steps:
CREATE TABLE t(a int primary key, b text);
CREATE INDEX t_b_idx ON t(b);
SELECT pg_relation_is_updatable('t_b_idx'::regclass, false);
-- server closed the connection unexpectedly
SELECT pg_column_is_updatable('t_b_idx'::regclass, 1::int2, false);
-- server closed the connection unexpectedly
Please take this into consideration.
Best regards,
Yilin Zhang
