Hi, On Thu, 22 Oct 2026 at 15:37, Daniel Gustafsson <[email protected]> wrote: > > > On 12 Oct 2026, at 21:15, Ayush Tiwari <[email protected]> wrote: > > > Thanks for the patch! It makes sense to me to have this function, makes > > the tests easier to follow. > > Thanks for review! > > > Small nit on the replace vs rewrite thing you mentioned: should we change > > the below comment too to use "replacing"? > > Fixed. > > > Also, I noticed the forked-backend SKIP block in > > src/test/ssl/t/004_sni.pl still skips 11 tests. Since we're removing the > > ok(unlink(...)) assertion, ig that should be 10 now. > > Right. The skip number isn't actually used for no_plan plans which we use so > the number isn't particularly useful, but since we do specify it the number > should match so: Fixed.
A v tiny nit: with v2 it looks like that number should be 8 now. > > On 13 Oct 2026, at 10:30, Nazir Bilal Yavuz <[email protected]> wrote: > > > LGTM. We might add these as well: > > > > diff --git a/src/test/ssl/t/SSL/Server.pm b/src/test/ssl/t/SSL/Server.pm > > Ah, good catch, fixed. Thanks for updating the patch, it looks good to me. Regards, Ayush
