On Thu, Oct 22, 2026 at 9:44 PM Fujii Masao <[email protected]> wrote: > > On Tue, Sep 22, 2026 at 5:54 PM solai v <[email protected]> wrote: > > There are no functional issues > > with the patch and it looks good to me. > > The patch looks good to me as well. Barring any objections, I will > commit it.
BTW, while removing PageIsPredicateLocked(), I found that the "INTERFACE ROUTINES" comment in predicate.c is outdated. For example, it lists RegisterPredicateLockingXid(void), although the function takes a TransactionId, and omits functions such as CheckForSerializableConflictOutNeeded() and ShareSerializableXact(). Rather than updating the list, isn't it better to remove it? The declarations are already available in the headers predicate.h, and maintaining a duplicate list seems likely to result in further omissions and outdated signatures. Thought? Regards, -- Fujii Masao
nocfbot-0002-Remove-the-redundant-interface-list-and-fix-funct.patch
Description: Binary data
