Hello Zhijie, On Sat, Oct 24, 2026 at 10:06 PM Zhijie Hou <[email protected]> wrote:
> But I'm not sure we need to change the comments above those early returns, > since > it's not this internal function's place to know whether the outer side > should > apply the transaction or not. > Thank you for the review and suggestion. Agreed. v2 attached keeps the original comment. > BTW, I noticed the other caller of pa_setup_dsm() in dsa.c has a similar > issue: > it doesn't pass this flag but does have a check for a NULL value, so that > path > is also unreachable, but that could be fixed in a separate patch. > Right, make_new_segment() has the same issue. There it means DSA_ALLOC_NO_OOM still errors out when we run out of segments, so callers like pgstat never get to do their cleanup. Attached as 0002. I think both should be backpatched. 0001 to 16, where parallel apply was added, and 0002 to 14, since that code is the same on all supported branches. Thoughts? Thanks, Baji Shaik
v2-0002-Make-DSA-honor-DSA_ALLOC_NO_OOM-when-out-of-DSM-s.patch
Description: Binary data
v2-0001-Fall-back-to-serializing-when-parallel-apply-runs.patch
Description: Binary data
